[graphite] Some small bug fixes and improvements
Thu Dec 11 17:58:00 GMT 2008
I just committed the attached patch to the graphite branch.
AMD - GNU Tools
On Thu, Dec 11, 2008 at 10:53 AM, Sebastian Pop <firstname.lastname@example.org> wrote:
> On Thu, Dec 11, 2008 at 9:31 AM, Tobias Grosser <email@example.com> wrote:
>> On Tue, 2008-12-09 at 16:38 -0600, Sebastian Pop wrote:
>>> On Tue, Dec 9, 2008 at 4:15 PM, Tobias Grosser <firstname.lastname@example.org> wrote:
>>> With this patch, do we fail more tests in the current testsuite? If
>>> not please apply.
>>> > * graphite.c (new_graphite_bb): Initialize GBB_STATIC_SCHEDULE.
>>> > (find_params_in_bb): Do not free data refs.
>>> ok. I would put a comment where you removed the free data refs to
>>> indicate that the problem is in the free_data_refs. I also got bitten
>>> by this once...
>> What comment would you put, and where. It seems this call to
>> free_data_ref is a remainder of code you removed in the bb copying
>> commit (142384).
>> Before we created new data_refs just to find parameters and removed them
>> later. Now we use the DATA_REFS of the gbb data structure. So we can not
>> remove any data ref during parameter detection.
>> But actually we should clean up later. Why have you removed the
>> free_data_refs() call in free_graphite_bb()? It seems also to work in
> Oh, here it was that free_data_refs that I removed! There is a call
> to BITMAP_FREE (DR_VOPS (dr)) that make some problems when called from
> graphite as we try to free a DR_VOPS not allocated. I will have to
> look more closely into this.
> Could you put this comment along with your patch?
> Sebastian Pop
> AMD - GNU Tools
> Index: graphite.c
> --- graphite.c (revision 142673)
> +++ graphite.c (working copy)
> @@ -1067,6 +1067,11 @@ free_graphite_bb (struct graphite_bb *gb
> if (GBB_DOMAIN (gbb))
> cloog_matrix_free (GBB_DOMAIN (gbb));
> + /* FIXME: free_data_refs is disabled for the moment, but should be
> + enabled.
> + free_data_refs (GBB_DATA_REFS (gbb)); */
> VEC_free (gimple, heap, GBB_CONDITIONS (gbb));
> VEC_free (gimple, heap, GBB_CONDITION_CASES (gbb));
> VEC_free (loop_p, heap, GBB_LOOPS (gbb));
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1365 bytes
Desc: not available
More information about the Gcc-patches