[PATCH] Fix gcc.dg/weak/weak-1.c on SPARC

Jakub Jelinek jakub@redhat.com
Wed Dec 10 10:39:00 GMT 2008

On Tue, Dec 09, 2008 at 06:27:57PM -0800, Ian Lance Taylor wrote:
> Eric Botcazou <ebotcazou@adacore.com> writes:
> > Ping.  Thanks in advance.
> >
> >> 2008-11-23  Eric Botcazou  <ebotcazou@adacore.com>
> >>
> >> 	* final.c (output_addr_const) <SYMBOL_REF>: Call assemble_external
> >> 	on the associated SYMBOL_REF_DECL node, if any.
> >
> > http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01218.html
> This is OK.

In this case I think the mark_symbol_refs_as_used calls from
sh, s390 and arm backends can go away.
The calls are always next to an assemble_integer call, and while
s390 and arm provide their own ASM_INTEGER hook, they either call
output_addr_const directly, or for non-CONST_{INT,VECTOR} they
call default_assemble_integer which calls output_addr_const as well.
Perhaps it isn't needed in output_operand either.

At least until PR38237 is fixed, calling assemble_external multiple
times is very much visible in the generated assembly.


More information about the Gcc-patches mailing list