[Patch, Fortran] PR 38415: procedure pointer assignment to abstract interface

Janus Weil jaydub66@googlemail.com
Sat Dec 6 12:50:00 GMT 2008


Committed as r142520 with Tobias' and Daniel's comments.
Thanks for the reviews :)


2008/12/6 Tobias Burnus <burnus@net-b.de>:
> Hi Janus,
>
> Your patch is OK, however, you should open a PR which tracks the
> missing checks and also notes the problem for intrinsics.
>
> Additionally, can you add a comment to the outcomment section like
> "/* TODO. See PR ... */".
>
> Furthermore, if you have a test case which fails with the additional
> check, can you add it to the test suite to make sure gfortran
> won't regress in the future?
>
> Tobias
>
>>> 2008-12-05  Janus Weil  <janus@gcc.gnu.org>
>>>
>>>        PR fortran/38415
>>>        * expr.c (gfc_check_pointer_assign): Added a check for abstract
>>>        interfaces in procedure pointer assignments.
>
>>> 2008-12-05  Janus Weil  <janus@gcc.gnu.org>
>>>
>>>        PR fortran/38415
>>>        * gfortran.dg/proc_ptr_2.f90: Extended.
>>>
>



More information about the Gcc-patches mailing list