Fix parallel make install

Jakub Jelinek jakub@redhat.com
Thu Dec 4 16:09:00 GMT 2008


On Thu, Dec 04, 2008 at 11:01:30AM -0500, Diego Novillo wrote:
> On Thu, Dec 4, 2008 at 10:58, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
> > * Diego Novillo wrote on Thu, Dec 04, 2008 at 04:46:14PM CET:
> >> On Thu, Dec 4, 2008 at 10:24, Alexandre Oliva <aoliva@redhat.com> wrote:
> >>
> >> > You phrase it as if there was no other way to avoid the race
> >> > condition.
> >>
> >> Well, removing finclude/ is still wrong, as it would remove the files
> >> installed by libgomp.  If the user did make install from <bld>/gcc/,
> >> the files installed by libgomp would be gone.
> >
> > That still doesn't answer the question whether, before this patch,
> > removing finclude/ early in the installation process was done
> > consciously, for example to remove files from an older installation
> > of GCC that, when not removed now, could cause some sort of trouble.
> >
> > Example: the GCC tree of two months ago bogusly installed file Foo.h
> > to finclude/, that, when not removed now, results in a malfunctioning
> > of current GCC.
> 
> That's a question for Jakub.  He added the original code and suggested
> that we shouldn't be removing finclude/  If anything needs to be
> removed at all, it will have to be done piecemeal.

We don't wipe include/ dir, so we shouldn't wipe finclude/ either.

	Jakub



More information about the Gcc-patches mailing list