[PATH]: PR middlend/38385 fix

Richard Guenther richard.guenther@gmail.com
Thu Dec 4 16:06:00 GMT 2008


On Thu, Dec 4, 2008 at 4:42 PM, Sebastian Pop <spop@gcc.gnu.org> wrote:
> On Thu, Dec 4, 2008 at 8:59 AM, Tomas Bily <tbily@suse.cz> wrote:
>> Hi,
>>
>>  This pr is caused because after removing bbs in generate_builtin
>> (tree-loop-distribution.c) some phis has bad incoming edges. This
>> patch tryes to fix it.
>>
>> Tested and bootstraped on x86_64-unknown-linux-gnu.
>> Ok for mainline ?
>>
>
> Looks good to me, but I cannot approve it.

I don't follow.  You create an edge from the preheader to the loop exit
and now use the values from the exit edge for that edge?  If we
are in loop-closed SSA form we should not need to care at all here.
It is more likely that we need to split some block before removing the
loop.

Richard.


> Thanks for the fix,
>
> Sebastian Pop
> --
> AMD - GNU Tools
>



More information about the Gcc-patches mailing list