Fix parallel make install

Alexandre Oliva aoliva@redhat.com
Thu Dec 4 15:25:00 GMT 2008


On Dec  4, 2008, Diego Novillo <dnovillo@google.com> wrote:

> On Wed, Dec 3, 2008 at 23:02, Alexandre Oliva <aoliva@redhat.com> wrote:
>> 
>> On Dec  2, 2008, Diego Novillo <dnovillo@google.com> wrote:
>> 
>> >  install-finclude-dir: installdirs
>> > -     -rm -rf $(DESTDIR)$(libsubdir)/finclude
>> > -     mkdir $(DESTDIR)$(libsubdir)/finclude
>> > +     $(mkinstalldirs) $(DESTDIR)$(libsubdir)/finclude
>> 
>> Err...  Wasn't this supposed to wipe out the contents of pre-existing
>> finclude?  Do we really want to change it so that it doesn't?

> Yes.  As I described in the original post, this had a race condition
> with libgomp, which also tries to install in finclude/

You phrase it as if there was no other way to avoid the race
condition. But it is possible to avoid it without leaving files from
earlier installs in place.  For example, introducing a top-level
dependency so that the above occurs first.

-- 
Alexandre Oliva           http://www.lsd.ic.unicamp.br/~oliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer



More information about the Gcc-patches mailing list