[PATCH][REVISED]: fix misc darwin9 hard-codings

Paolo Bonzini bonzini@gnu.org
Mon Dec 1 08:39:00 GMT 2008


Andreas Tobler wrote:
> Jack Howarth wrote:
>> Previously approved patch with revised change log
>> as requested by Andreas Tobler.
>>               Jack
>>
>> 2008-11-29  Jack Howarth  <howarth@bromo.med.uc.edu>
>>
>>     configure.ac: Expand to darwin10 and later.
>>     configure: Regenerate.
>>     gcc/testsuite/gcc.dg/darwin-comm.c: Expand to darwin10 and later.
>>     libjava/configure.ac: Expand to darwin10 and later.
>>     libjava/configure: Regenerate.
>>     libjava/testsuite/lib/libjava.exp: Expand to darwin10 and later.
> 
> Jack, you only need to send the diffs from the sources, you do not need
> to send the configure diffs. They might be huge and confusing. So in the
> future, only configure.ac stuff, the rest should be reproducible by
> everyone. (Given they have the right tools :)

Well, in this case sending configure patches was better.  Jack took the
opportunity to fix bad m4 quoting, and seeing the effect in the
configure scripts allowed me to review the patch without opening
configure.ac.  But in general, Andreas is right. :-)

Paolo



More information about the Gcc-patches mailing list