[RFA:] PR37170, extern weak broken, like for gcc.dg/weak/weak-1.c

Rafael Espindola espindola@google.com
Fri Aug 29 12:57:00 GMT 2008


>> I might be able to help remove some FE calls to assemble_external.

I started with the C++ FE. The results are interesting. Just removing
all the 3 remaining calls produced no regressions  on X86_64 or i686
linux. I am trying to get a PPC64 machine to do a bit more testing,
but decided to post the patch earlier.

The bad news is that this was not one of the C++ problems in LTO.

2008-08-28  Rafael Espindola  <espindola@google.com>

	* class.c (build_vtbl_ref_1): Don't call assemble_external.
	* decl2.c (mark_used): Don't call assemble_external.
	* init.c (build_vtbl_address): Don't call assemble_external.

> Thanks.
>
> brgds, H-P
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047
-------------- next part --------------
A non-text attachment was scrubbed...
Name: external.patch
Type: text/x-diff
Size: 1212 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080829/cb850025/attachment.bin>


More information about the Gcc-patches mailing list