[RF SPU testing] separate errors.c and diagnostic.c functions (try2)

Manuel López-Ibáñez lopezibanez@gmail.com
Mon Aug 25 08:59:00 GMT 2008


PING: http://gcc.gnu.org/ml/gcc-patches/2008-08/msg01713.html

2008/8/22 Manuel López-Ibáñez <lopezibanez@gmail.com>:
> The files errors.c and errors.h define and declare some diagnostics
> functions that are used by the gen* programs. On the other hand,
> toplev.h and diagnostic.c declare and define different diagnostics
> functions used by the rest of the compiler.
>
> We have been trying to keep the declarations of error, warning, etc.
> found in errrors.h and toplev.h compatible. However, this has no
> future at all. They do not need to be compatible since they are not
> (or should not be) used in the same places. Moreover, being compatible
> has allowed errors.h to sneak into some compiler files where it does
> not belong. (I would prefer if errors.h and errors.c would rather be
> called generrors.h and generrors.c)
>
> This version should work in SPU, although I cannot test it so testing
> in that (and any other target) is appreciated.
>
>
> Bootstrapped and regression tested on x86_64-unknown-linux-gnu with
> --enable-languages=all,ada
>
> OK for trunk?
>
> 2008-08-22  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>
>        * Makefile.in: Update dependencies.
>        * errors.c (warning): Remove unused parameter 'opt'. Returns
>        'void'.
>        * errors.h: Remove bogus comment about compatibility.
>        (warning): Update declaration.
>        * genautomata.c: Update all calls to warning.
>        * gimple.c: Do not include errors.h. Include toplev.h.
>        * tree-ssa-structalias.c: Do not include errors.h.
>        * omega.c: Likewise.
>        * tree-ssa-reassoc.c: Likewise.
>        * config/spu/spu-c.c: Likewise.
>        * config/spu/t-spu-elf: Update dependencies.
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix-generrors.diff
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080825/22941189/attachment.ksh>


More information about the Gcc-patches mailing list