make grokfield handle locations

Janis Johnson janis187@us.ibm.com
Wed Aug 20 19:15:00 GMT 2008


On Wed, 2008-08-20 at 13:42 -0400, Aldy Hernandez wrote:

> I am attaching a patch to our testsuite harness that will allow for
> testing columns with:
> 
> 	{ dg-{error,warning} "COL:rest of message here" }
> 
> It is the least invasive, consistent solution I have found.  
> 
> I dislike the suggestion of:
> 
> 	{ dg-warning "does not declare anything" "" { target *-*-* } "COL" }
> 
> because it's overly verbose.  However, at this point I just want to fix
> location information throughout the compiler, and not spend the rest of
> the week coming up with a testsuite solution that will please everyone.
> 
> If anyone has a solution that is compliant with everything and everyone,
> and they're willing to code it, I'll gladly use it.

I like the testsuite changes.  They'll only work for C until other
languages switch support to the new dg-{warning,error} in gcc-dg.exp,
but this is another incentive to do that work.  Thanks!

Janis



More information about the Gcc-patches mailing list