Graphite middle-end parts review

[Sebastian Pop]

Hi,

I'm going through the review comments one by one, and I will post a
patch for addressing each concern.

On Thu, Aug 7, 2008 at 7:13 AM, Richard Guenther <rguenther@suse.de> wrote:
> Index: gcc/doc/invoke.texi
> ===================================================================
> --- gcc/doc/invoke.texi (.../trunk)     (revision 138275)
> +++ gcc/doc/invoke.texi (.../branches/graphite) (revision 138569)
> @@ -5941,6 +5942,15 @@ at @option{-O} and higher.
>  Perform linear loop transformations on tree.  This flag can improve cache
>  performance and allow further loop optimizations to take place.
>
> +@item -floop-block
> +Perform loop blocking transformations on loops.
> +
> +@item -floop-strip-mine
> +Perform loop strip mining transformations on loops.
> +
> +@item -floop-interchange
> +Perform loop interchange transformations on loops.
> +
>
> A bit more verbose descriptions would be nice.  While people might
> know what interchange is I bet with strip mining they are lost.
> Remember this is supposed to be user-level documentation.
>

Here is a part of the patch from Harsha at
http://gcc.gnu.org/viewcvs?view=rev&revision=139020
Is this enough or should the text be more explicit than this?

--- branches/graphite/gcc/doc/invoke.texi	2008/08/12 14:35:54	139019
+++ branches/graphite/gcc/doc/invoke.texi	2008/08/12 16:52:21	139020
@@ -5943,13 +5943,19 @@
 performance and allow further loop optimizations to take place.

 @item -floop-block
-Perform loop blocking transformations on loops.
+Perform loop blocking transformations on loops.  Blocking strip mines
+each loop in the loop nest such that the memory accesses of the
+element loops fit inside the L1 cache.

 @item -floop-strip-mine
-Perform loop strip mining transformations on loops.
+Perform loop strip mining transformations on loops.  Strip mining
+splits a loop into two nested loops.  The outer loop has strides
+equal to the strip size and the inner loop has strides of the
+original loop within a strip.

 @item -floop-interchange
-Perform loop interchange transformations on loops.
+Perform loop interchange transformations on loops.  Interchanging
+two nested loops switches the inner and outer loops.

 @item -fcheck-data-deps
 @opindex fcheck-data-deps