[trunk] PATCH: unique names for patches.

Ralf Wildenhues Ralf.Wildenhues@gmx.de
Fri Aug 1 15:48:00 GMT 2008


* Basile STARYNKEVITCH wrote on Fri, Aug 01, 2008 at 05:37:13PM CEST:
> Ralf Wildenhues wrote:
>> a couple of nits:

> Thanks for the suggestions. I followed them in the updated patch to  
> trunk rev.138523 attached.

Please go through your patch and fix each place matching '[a-zA-Z0-9]('
(i.e., an open parenthesis after a macro or function name).  There are
about a dozen of them.

> What I don't know is if some passes names are mentioned in the testsuite.

FWIW I don't know either.  If you haven't done regression testing yet,
which I assume you didn't because you didn't say otherwise, I think now
would be a good time to do it (and report back once your patch is
regression-free).

Cheers,
Ralf



More information about the Gcc-patches mailing list