[trunk] PATCH: unique names for patches.

[Basile STARYNKEVITCH]

Hello All,

Ralf Wildenhues wrote:
> Hello Basile,
> 
> a couple of nits:
 > [....]

Thanks for the suggestions. I followed them in the updated patch to 
trunk rev.138523 attached.

> I further assume you've tried to expose the failure with naming two
> passes identically?

Yes I did. It wasn't hard, several passes used to be homonymous :-(

What I don't know is if some passes names are mentioned in the testsuite.

Now gcc/ChangeLog is:

2008-08-01  Basile Starynkevitch  <basile@starynkevitch.net>

         * Makefile.in: Change dependencies for passes.c.
         (pass_is_dumpable) New function.
         * cfgrtl.c (pass_free_cfg): Added name.
         * cgraphbuild.c (pass_build_cgraph_edges)
         (pass_rebuild_cgraph_edges): Added name.
         * dce.c (pass_ud_rtl_dce, pass_fast_rtl_dce): Changed name.
         * df-core.c (pass_df_initialize_opt, pass_df_initialize_no_opt):
         Changed name.
         * except.c (pass_set_nothrow_function_flags): Added name.
         * final.c (pass_final, pass_clean_state): Added name.
         * function.c (pass_init_function, pass_leaf_regs): Added name.
         * ipa-inline.c (pass_inline_parameters): Added name.
         * passes.c: include hashtab.h.
         (hash_pass, eq_pass): New functions.
         (pass_rest_of_compilation): Added name.
         (register_dump_files_1): Test if pass_is_dumpable.
         (next_pass_1): Check if pass is unique when ENABLE_CHECKING.
         (init_optimization_passes): Create pass_hash table when
         ENABLE_CHECKING.
         (pass_init_dump_file): Test if pass_is_dumpable.
         * reg-stack.c (pass_stack_regs): Added name.
         * stack-ptr-mod.c (pass_stack_ptr_mod): Added name.
         * statistics.c (statistics_fini_pass): Test if pass_is_dumpable.
         * tree-cfg.c (pass_warn_function_return)
         (pass_warn_function_noreturn): Changed name.
         * tree-dfa.c (pass_referenced_vars): Added name.
         * tree-eh.c (pass_lower_eh): Changed name.
         * tree-optimize.c (pass_all_optimizations): Added name.
         * tree-pass.h (struct opt_pass): Changed comment about name field.
         * tree-ssa-alias.c (pass_reset_cc_flags): Added name.
         * tree-ssa-dse.c (pass_dce): Changed name.
         * tree-ssa-loop.c (pass_record_bounds): Added name.
         * tree-ssa.c (pass_early_warn_uninitialized)
         (pass_late_warn_uninitialized): Added name.
         * doc/passes.texi (Pass manager): Mention that passes should have
         a unique name.

On my Debian/Sid/amd64 x86_64-unknown-linux-gnu the patch bootstraps 
with ..../configure  '--enable-checks=all' '--disable-multilib' 
'--enable-languages=c,c++'

Ok for trunk?

Thanks.

-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-trunk138523-unique-passname.diff
Type: text/x-patch
Size: 18013 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20080801/b7927b1d/attachment.bin>