C++ patch ping
Mark Mitchell
mark@codesourcery.com
Mon Apr 28 20:43:00 GMT 2008
Jakub Jelinek wrote:
> - http://gcc.gnu.org/ml/gcc-patches/2008-04/msg01609.html PR c++/35650
I think this patch is OK. As you say, we could also change
reference_binding or initialize_reference, but the general policy in the
front end has been to resolve single OVERLOADs at the point of lookup.
In fact, if we were you going to make a more substantial change here, it
would probably be to have the USING_DECL record only a FUNCTION_DECL,
rather than an OVERLOAD.
> - http://gcc.gnu.org/ml/gcc-patches/2008-04/msg01559.html PR c++/35987
This is OK, too, though I would prefer using error_operand_p to the
direct comparision with error_mark_node. In this case, error_mark_node
is probably correct -- but using error_operand_p for expressions is more
mnemonic.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gcc-patches
mailing list