subreg rtl documentation

[Richard Sandiford]

Kenneth Zadeck <zadeck@naturalbridge.com> writes:
> Richard Sandiford wrote:
>> Thanks Kenny, looks good to me.  Couple of nits:
>>
>> Kenneth Zadeck <Kenneth.Zadeck@NaturalBridge.com> writes:
>>   
>>> It is seldom necessary to wrap hard registers in @code{subreg}s; such
>>> registers would normally reduce to a single @code{reg} rtx.  This use of
>>> @code{subregs} is discouraged and my not be supported in the future.
>>>     
>>
>> s/my/may/
>>
>>   
>>> @code{Subregs} of @code{subregs} are not supported.  Using
>>> @code{simplify_gen_subreg} is the recommended way to avoid this problem.
>>>     
>>
>> Local style seems to not be to capitalise keywords at the start of
>> a sentence, or to put the plural in @code{} font.  So:
>>
>> s/@code{Subregs}/@code{subreg}s/
>> s/@code{subregs}/@code{subreg}s/
>>
>> Richard
>>   
> 2008-04-07  Kenneth Zadeck <zadeck@naturalbridge.com>
>
>     doc/rtl.texi: Rewrite of subreg section.
>    
> final version with these changes committed as revision 133982.

I don't want to make a fuss, but for the record, as someone involved in
writing these changes, I feel very uncomfortable seeing a patch like
this being applied without a maintainer approving it.  It certainly
doesn't qualify as obvious, and I don't think there's any precedent
for "approval by lack of complaint".  I was also hoping that an
explicit approval would give the new documentation some authority.

Also for the record, I know you did this in good faith, having asked
others first.

Richard