[PATCH][TUPLES] Fix for builtin expander

Diego Novillo dnovillo@google.com
Wed Apr 2 02:51:00 GMT 2008


2008/4/1 Doug Kwan (關振德) <dougkwan@google.com>:

> Bug fixed.  Mounting NFS volumes over VPN sucks.  I thought Firefox
>  got my patch.

NFS over VPN?  Wow, you *are* patient.

> +   /* FIXME tuples.  */
> +  ann = tree_common_ann (orig_exp);
> +  if (ann)
> +    stringop_block_profile (ann->stmt, &expected_align, &expected_size);
> +

Mention what exactly needs fixing here.  It's not immediately
obvious.  This is to protect for CALL_EXPRs materialized during RTL
expansion, right?

> @@ -11047,7 +10778,7 @@ validate_arg (const_tree arg, enum tree_
>     VOID_TYPE.  */
>
>  bool
> -validate_arglist (const_gimple call, ...)
> +validate_gimple_arglist (const_gimple call, ...)

Add a note in the comment stating that this is the GIMPLE
equivalent of validate_arglist, which operates on GENERIC.
Long term we will want to remove validate_arglist, but we cannot
do that until the RTL expander works from GIMPLE directly.

OK with those changes.


Diego.


More information about the Gcc-patches mailing list