[PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.
Richard Guenther
richard.guenther@gmail.com
Tue Apr 1 22:54:00 GMT 2008
On Wed, Apr 2, 2008 at 12:50 AM, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
> Hello Seongbae,
>
> * Seongbae Park (박성배, 朴成培) wrote on Mon, Mar 31, 2008 at 11:53:36PM CEST:
>
> > The patch updated per comment has been applied to the mainline as
> > revision 133774.
> [...]
>
> > ChangeLog
> > 2008-03-31 Seongbae Park <seongbae.park@gmail.com>
> >
> > * Makefile.tpl (.NOTPARALLEL): Serialize stageprofile libiberty.
> > * Makefile.in (.NOTPARALLEL): Regenerate.
>
> > +.NOTPARALLEL: all-stageprofile-libiberty
> > +
>
> Not sure if you're aware of it, but with current GNU make, listing
> prerequisites to .NOTPARALLEL doesn't have any effect; the above will
> simply cause 'make' not to run any rules in this Makefile in parallel.
>
> Since this hurts parallel build performance, can't we formulate the
> required ordering in terms or order-only dependencies? Something like
>
> all-stageprofile-libiberty: | $(targets_that_need_to_run_earlier)
>
> $(targets_that_need_to_run_later): | all-stageprofile-libiberty
>
> You may have to check that this doesn't expose the make bug, though:
> <http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html>.
Doh, and I thought the slow performance was my imagination ... ;)
Seongbae, please do something about this quickly.
Thanks,
Richard.
More information about the Gcc-patches
mailing list