[tuples] [patch] Fix in_phi in verify_expr

Rafael Espindola espindola@google.com
Tue Apr 1 15:28:00 GMT 2008


>  Btw, I was suggesting the following in place of your verify_stmts parts:

That is exactly what I have in last patch :-)

>  Index: tree-cfg.c
>  ===================================================================
>  --- tree-cfg.c  (revision 133749)
>  +++ tree-cfg.c  (working copy)
>  @@ -4338,7 +4338,7 @@ verify_stmts (void)
>
>                  are not considered gimple values.  */
>               else if (TREE_CODE (t) != SSA_NAME
>                        && TREE_CODE (t) != FUNCTION_DECL
>  -                      && !is_gimple_val (t))
>  +                      && !is_gimple_min_invariant (t))
>                 {
>                   error ("PHI def is not a GIMPLE value");
>                   debug_generic_stmt (phi);
>  @@ -4346,13 +4346,6 @@ verify_stmts (void)
>                   err |= true;
>                 }
>
>  -             addr = walk_tree (&t, verify_expr, (void *) 1, NULL);
>  -             if (addr)
>  -               {
>  -                 debug_generic_stmt (addr);
>  -                 err |= true;
>  -               }
>  -
>               addr = walk_tree (&t, verify_node_sharing, visited, NULL);
>               if (addr)
>                 {
>
>
>  Richard.
>

Cheers,
-- 
Rafael Avila de Espindola

Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland

Registered in Dublin, Ireland
Registration Number: 368047



More information about the Gcc-patches mailing list