[PATCH]: Add -Wcast-qual to the bootstrap warning flags

Andrew Pinski pinskia@gmail.com
Mon Sep 24 08:31:00 GMT 2007


On 9/23/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:

> +       asprintf (CONST_CAST(char **, &m68k_library_id_string),
                                              ^
Missing space.  Also this looks wrong anyways.

> +      cselib_val *e = cselib_lookup (CONST_CAST_RTX(x), GET_MODE (x), 0);

Likewise.

> +      cselib_val *e = cselib_lookup (CONST_CAST_RTX(y), GET_MODE (y), 0);

And again.


Can you double check all of the added CONST_CAST* to make sure they
have the needed space between the macro name and the parentheses?

Also why can't cselib_lookup take const_rtx?  I think you need to take
more time to think about all of these const_* changes before just
adding CONST_CAST*.

Thanks,
Andrew Pinski



More information about the Gcc-patches mailing list