[PATCH] Cost of inlining when the function has call to a target-specific builtin

Richard Guenther richard.guenther@gmail.com
Sat Sep 22 14:08:00 GMT 2007


On 9/22/07, Pranav Bhandarkar <pranav.bhandarkar@gmail.com> wrote:
> Hi,
>
> Really sorry for some confusion on my part. When I said,
> > > I did a quick scan through a few backends and didnt find non-negigible
> > > call cost target specific builtins.
> I am sorry I meant size costs here.
>
> > I think it is good enough for now given your quick scan.  That is,
> > I'd propose to add a new weight in the eni_weights structure for
> > target builtins and use that. Given that your patch doesn't introduce
> > sophisticated use of the target hook in any target and we're in stage3
> > already.
>
> Thanks. I am attaching a patch. I have added a new field to the
> eni_weights structure and initialized it in init_inline_once (). For
> the size weight I have initialized it to 1 and for the time weight I
> have initialized it to 10 at present since there is no data to back
> any other value and also It would not change behaviour for most
> backends now that we are in stage 3. For the inlining weight too, I
> have initialized it to 1.
>
> Is this ok ?

This is ok supposed you bootstrapped and regtested this change.

Thanks,
Richard.



More information about the Gcc-patches mailing list