RFA: Fix assert4.c test for h8300

Nick Clifton nickc@redhat.com
Wed Sep 19 11:54:00 GMT 2007

Hi Jeff, Hi Kazu,

  The gcc test gcc.dg/cpp/assert4.c is currently failing for the h8300
  target because it checks for a symbol called __h8300__ but the
  target defines a symbol called __H8300__.

  The attached patch is a straightforward fix for the problem, but I
  am not sure if it counts as obvious, because I do not know who is
  right here, the test case or the h8300 backend.

  So, should I apply this patch ?


2007-09-19  Nick Clifton  <nickc@redhat.com>

	* gcc.dg/cpp/assert4.c: Fix expected h8300 preprocessor define.

Index: gcc/testsuite/gcc.dg/cpp/assert4.c
--- gcc/testsuite/gcc.dg/cpp/assert4.c	(revision 128597)
+++ gcc/testsuite/gcc.dg/cpp/assert4.c	(working copy)
@@ -209,7 +209,7 @@
 # error
-#if defined __h8300__ 
+#if defined __H8300__ 
 # if !#cpu(h8300) || !#machine(h8300) \
   || (defined __H8300__ && (!#cpu(h8300) || !#machine(h8300))) \
   || (defined __H8300H__ && (!#cpu(h8300h) || !#machine(h8300h))) \

More information about the Gcc-patches mailing list