[patch] Preparations for SYSV/MS ABI attributes in middle-backend may before stage 3 and implementation in i386
Mark Mitchell
mark@codesourcery.com
Tue Sep 18 22:27:00 GMT 2007
Kai Tietz wrote:
>> Furthermore, I would argue that the attributes here should be recorded
>> *only* on the type, in order to avoid duplication. That's not strictly
>> speaking necessary, but calling conventions are certainly properly
>> thought of as a property of types, not of declarations.
>
> Ok, I changed documentation and implementation for this patch (see
> attachment).
Thank you.
-@defmac OUTGOING_REG_PARM_STACK_SPACE
+@defmac OUTGOING_REG_PARM_STACK_SPACE (@var{fntype})
Define this to a nonzero value if it is the responsibility of the caller
-to allocate the area reserved for arguments passed in registers.
+to allocate the area reserved for arguments passed in registers represented
+by @var{fntype}, which can be zero if GCC is calling a library function.
I think this would be better as:
Define this to a nonzero value if it is the responsibility of hte
caller to allocate the area reserved for arguments passed in registers
when calling a function of @var{fntype}. @var{fntype} may be NULL
if the function called is a library function.
Also, I don't see any documentation for the change to RETURN_IN_MEMORY.
But, other than that I'm OK with this version of the patch, assuming
that the x86 folks think the backends bits are OK.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gcc-patches
mailing list