[PATCH] reorganize simplify_const_relational_operation

Paolo Bonzini paolo.bonzini@lu.unisi.ch
Tue Sep 18 16:51:00 GMT 2007


Eric Botcazou wrote:
>> I didn't make this modification, as there are occurrences of the "enum
>> for a bitmask" idiom elsewhere (for example for the LCT_* constants in
>> rtl.h, and the FMT_* constants in c-format.h).
> 
> Huh?

Oops, I was going by memory on this one.  It is ECF_* which is a 
bitfield, not LCT_* (similar purpose, different names...).  And of 
course, "grep LCT_.*4" was only good to confirm my flaky memory.

> enum format_lengths
> {
>   FMT_LEN_none,
>   FMT_LEN_hh,
>   FMT_LEN_h,
>   FMT_LEN_l,
>   FMT_LEN_ll,
>   FMT_LEN_L,
>   FMT_LEN_z,
>   FMT_LEN_t,
>   FMT_LEN_j,
>   FMT_LEN_H,
>   FMT_LEN_D,
>   FMT_LEN_DD,
>   FMT_LEN_MAX
> };

But this time I had checked right :-) -- it is not this FMT_*, but the 
one just below:

   /* This format converts arguments of types determined by the
      format string.  */
   FMT_FLAG_ARG_CONVERT = 1,
   /* The scanf allocation 'a' kludge applies to this format kind.  */
   FMT_FLAG_SCANF_A_KLUDGE = 2,
   /* A % during parsing a specifier is allowed to be a modified % rather
      that indicating the format is broken and we are out-of-sync.  */
   FMT_FLAG_FANCY_PERCENT_OK = 4,

Paolo



More information about the Gcc-patches mailing list