[PATCH][3/3] ColdFire V2 pipeline description and scheduler hooks

Maxim Kuvyrkov maxim@codesourcery.com
Thu Sep 13 19:05:00 GMT 2007


Andreas Schwab wrote:
> Maxim Kuvyrkov <maxim@codesourcery.com> writes:

...

>> +  gcc_assert (recog_memoized (insn) >= 0);
> 
> Can this have a side effect?  The argument of gcc_assert must not have
> side effects since it can be optimized out with --disable-checking.

...

>> +  if (reload_completed)
>> +    /* Dump statistics.  */
>> +    {
>> +      if (sched_verbose >= 6 || msched_split_verbose_flag)
>> +	{
>> +	  const char *fn;
>> +
>> +	  if (msched_split_verbose_flag)
>> +	    fn = "sched-split.log";
>> +	  else
>> +	    fn = NULL;
>> +
>> +	  m68k_sched_dump (sched_dump_split_class, fn);
>> +	}
> 
> I don't see the point of having a separate dump file, moreover with a
> fixed name.

Andreas, thank you for your review.  I've fixed issues you pointed out.

Attached you find immediate fixes (fsf-cf-sched-v2.diff) and updated 
patch (fsf-cf-sched-v2.patch).


Thanks,

Maxim
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fsf-cf-sched-v2.diff
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20070913/41ae15fc/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fsf-cf-sched-v2.ChangeLog
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20070913/41ae15fc/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fsf-cf-sched-v2.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20070913/41ae15fc/attachment-0002.ksh>


More information about the Gcc-patches mailing list