[patch] Loop distribution for single nested loops
Sebastian Pop
sebpop@gmail.com
Thu Sep 13 12:50:00 GMT 2007
On 9/12/07, Zdenek Dvorak <rakdver@kam.mff.cuni.cz> wrote:
> I think tree_duplicate_loop_to_edge_cfg needs to be rewritten, as
> some parts of it duplicate functionality existing elsewhere; but I can
> take care of that when the patch is in mainline.
>
Thanks.
> > * tree-data-ref.c (debug_data_dependence_relations): New.
> > (dump_data_dependence_relation): Call dump_data_reference.
> > (dr_may_alias_p, compute_all_dependences): Use DR_IS_WRITE.
>
> It is not clear why you need to rename !DR_IS_READ to DR_IS_WRITE?
>
Ok, this is not really needed, it's just that I wanted that part of
the source to be readable. I will remove that part of the patch.
> > + ldist_update_phis_for_duplicate_loop (loop, res);
> > + rename_variables_in_loop (res);
>
> I do not understand this -- why do you need to rename the variables?
>
It's probably just a typo, as I followed what the vectorizer was doing
after loop duplication.
>
> I have just went over the patch quickly, but otherwise it seems fine to
> me.
>
Thanks for the quick review,
Sebastian
More information about the Gcc-patches
mailing list