[patch] restore bootstrap on ppc

Zdenek Dvorak rakdver@kam.mff.cuni.cz
Wed Sep 12 12:11:00 GMT 2007


Hello,

> > it looks like this is only performance related patch that might've
> > caused today regression on gzip and gcc:
> > http://www.suse.de/~gcctest/SPEC-britten/CINT/sandbox-britten/recent.html
> > http://www.suse.de/~gcctest/SPEC-britten/CINT/sandbox-britten/200709111625.int/
> > It seems quite serious, so hopefully there is way around (or it might be
> > a noise even if there was no changes in setup, we should see next run
> > relatively shortly)
> 
> This patch was for correctness only.  Another way to write the result
> after the patch would be
> 
>       if ((TYPE_OVERFLOW_UNDEFINED (ctype)
>            || (TREE_CODE (ctype) == INTEGER_TYPE && TYPE_IS_SIZETYPE (ctype)))
>           && ((code == MULT_EXPR && tcode == EXACT_DIV_EXPR)
>               || (tcode == MULT_EXPR && code == EXACT_DIV_EXPR))

not quite -- you would need code == EXACT_DIV_EXPR || code ==
TRUNC_DIV_EXPR || code == ..., for all DIV variants.

Zdenek



More information about the Gcc-patches mailing list