[RFA:] testsuite: don't run gcc.dg/cpp/trad/include.c for newlib

Janis Johnson janis187@us.ibm.com
Tue Sep 11 18:32:00 GMT 2007


On Tue, 2007-09-11 at 14:26 +0200, Hans-Peter Nilsson wrote:
> A change on 2007-09-07 caused newlib to use ## when including
> this file, effectively regressing this test (thus holding back
> auto-updates for my autotester).  I can't say newlib is wrong in
> using this standard construct, particularly as __STDC__=1
> here...
> 
> Using a standard file like this is very brittle and this test
> has been changed at least twice before for similar reasons, so
> I'd like to suggest this test be changed *not* to include a
> standard file, but instead use and rely on -I to include
> <>-delimeted files, and a new file trad_include.h be included.
> 
> But until then, ok to commit?
> 
> :ADDPATCH testsuite cpp:

:REVIEWMAIL: OK

With the changes from your follow-on mail.

Janis



More information about the Gcc-patches mailing list