[PATCH] fix DPD dfp to bfp conversions in libgcc

Ben Elliston bje@au1.ibm.com
Tue Sep 11 04:04:00 GMT 2007


Hi Janis

This patch is approved, however, just a couple of comments:

> The submitter of 30013, Nelson H.F. Beebe, doesn't have an FSF
> copyright assignment for GCC.  Should I add his name to the ChangeLog
> entry?  I could pull the sprintf format changes into a separate PR and
> credit him with that patch; in the meantime many of the new tests
> would fail, proving the value of his contribution.

My recollection is that Nelson's patch was small enough to not require a
copyright assignment.  However, it was a while ago that I last looked at
this PR.  Please use your own judgement (or ask an SC member) if an
assignment is required.

> +/* Don't use LIBGCC2_HAS_XF_MODE or LIBGCC2_HAS_TF_MODE here because
> +   we need to know the size of long double that the C library supports,
> +   and at most of of these can be true.  */

This comment just needs a bit of re-wording.  :-)

Thanks,
Ben



More information about the Gcc-patches mailing list