[PATCH][modulo-sched] New target hook to calculate MII

Ayal Zaks ZAKS@il.ibm.com
Mon Sep 10 07:35:00 GMT 2007


Revital1 Eres/Haifa/IBM wrote on 10/09/2007 09:09:04:

> gcc-patches-owner@gcc.gnu.org wrote on 09/09/2007 18:37:08:
>
> > On 9/9/07, Revital1 Eres <ERES@il.ibm.com> wrote:
> > >
> > > Hello,
> > >
> > > This patch adds new target hook to calculate MII.
> > >
> > > I am currently testing it on ppc64 (only C due to recent failure
> > > with mainline on ppc); spu and x86_64; with no regressions so far.
> > >
> > > O.K. for mainline once the testing is completed?
> >
> > The documentation should say what this should implement, not
> > how the hook is used.  It would be also nice to document what
> > happens in the default case if this hook is not implemented.
>
> Thanks for the comment. I've changed the wording as you suggested.
> OK to commit?
>


Just a minor comment - you may want to add a bounds check:

>+      int p = get_pipe (insn) + 2;

assert (p >= 0);
assert (p < 4);
>+      t[p]++;

Ayal.


> Thanks,
> Revital
>
> [attachment "patch_mii_10_9.txt" deleted by Ayal Zaks/Haifa/IBM]



More information about the Gcc-patches mailing list