[incremental] Patch: FYI: fix pex call

Tom Tromey tromey@redhat.com
Thu Sep 6 16:54:00 GMT 2007


>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:

>> if (done)
>> kill (pid, SIGTERM);
>> The explicit call to pex_get_status bypasses this and lets the
>> subprocess finish.

Ian> OK, makes sense.  Thanks for looking at it.

How about this documentation patch?

Tom

libiberty/ChangeLog:
2007-09-06  Tom Tromey  <tromey@redhat.com>

	* pexecute.txh (pex_free): Document process killing.

include/ChangeLog:
2007-09-06  Tom Tromey  <tromey@redhat.com>

	* libiberty.h (pex_free): Document process killing.

Index: libiberty/pexecute.txh
===================================================================
--- libiberty/pexecute.txh	(revision 128189)
+++ libiberty/pexecute.txh	(working copy)
@@ -265,7 +265,9 @@
 
 @deftypefn Extension void pex_free (struct pex_obj @var{obj})
 
-Clean up and free all data associated with @var{obj}.
+Clean up and free all data associated with @var{obj}.  If you have not
+yet called @code{pex_get_times} or @code{pex_get_status}, this will
+try to kill the subprocesses.
 
 @end deftypefn
 
Index: include/libiberty.h
===================================================================
--- include/libiberty.h	(revision 128189)
+++ include/libiberty.h	(working copy)
@@ -1,6 +1,6 @@
 /* Function declarations for libiberty.
 
-   Copyright 2001, 2002, 2005 Free Software Foundation, Inc.
+   Copyright 2001, 2002, 2005, 2007 Free Software Foundation, Inc.
    
    Note - certain prototypes declared in this header file are for
    functions whoes implementation copyright does not belong to the
@@ -541,7 +541,8 @@
 extern int pex_get_times (struct pex_obj *, int count,
 			  struct pex_time *vector);
 
-/* Clean up a pex_obj.  */
+/* Clean up a pex_obj.  If you have not called pex_get_times or
+   pex_get_status, this will try to kill the subprocesses.  */
 
 extern void pex_free (struct pex_obj *);
 



More information about the Gcc-patches mailing list