[incremental] Patch: FYI: fix pex call
Ian Lance Taylor
iant@google.com
Thu Sep 6 16:02:00 GMT 2007
Tom Tromey <tromey@redhat.com> writes:
> >>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:
>
> Ian> Tom Tromey <tromey@redhat.com> writes:
> >> And, we call pex_get_status. Calling this seems to let 'as' finish
> >> properly -- I thought it was optional but it does seem to make a
> >> difference.
>
> Ian> This shouldn't be required, as pex_free should do it when necessary.
> Ian> It would be nice to track this down and fix it in the pex code.
>
> I debugged and it comes from this code in pex_unix_wait:
>
> if (done)
> kill (pid, SIGTERM);
>
> The explicit call to pex_get_status bypasses this and lets the
> subprocess finish.
OK, makes sense. Thanks for looking at it.
Ian
More information about the Gcc-patches
mailing list