PATCH: break MIPS16 TLS
Jakub Jelinek
jakub@redhat.com
Wed Sep 5 14:48:00 GMT 2007
On Tue, Sep 04, 2007 at 08:33:17AM -0400, Sandra Loosemore wrote:
> Richard and I have previously been discussing this change in the context
> of the MIPS16 function attributes patch. Yesterday we had some internal
> discussion and realized we were talking about doing different things;
> so, for avoidance of ambiguity, this patch is my current understanding
> of the change Richard wants me to make. It's actually completely
> independent of the MIPS16 function attributes patch, so I've split it
> off for separate consideration.
>
> I'm still trying to figure out what to do with the testsuite, since this
> change intentionally breaks all the TLS tests with -mips16.
I don't see how this can be a good thing.
If the target can't support taking address of a __thread variable,
then it should IMNSHO use emutls.
Emutls was added so that all targets can support __thread and so that
code can assume it and use it portably. If MIPS16 has crippled __thread
support, then that's suddenly not true.
Jakub
More information about the Gcc-patches
mailing list