[PATCH, Fortran] PROCEDURE declarations

Janus Weil jaydub66@googlemail.com
Tue Sep 4 11:28:00 GMT 2007


2007/9/4, Tobias Burnus <burnus@net-b.de>:
> Minor nit: The following error message is given for inheriting the
> interface from intrinsic procedures (which can be used as actual
> argument); this is valid, but not yet supported.
>
> I find the following a bit misleading
>
> +      gfc_error ("Intrinsic procedure '%s' not supported "
> +            "in PROCEDURE statement at %C", proc_if->name);
>
> This sounds a bit as if it is invalid code.
>
> I would like to see at least a "yet" in the error message:
>    "Intrinsic procedure '%s' not yet supported in PROCEDURE statement at %C"

Actually I had the "yet" in this error message, but removed it because
some other Tobias didn't like it ;)

> or something like the following
>   "Support for intrinsic procedure '%s' in PROCEDURE statement at %C not
> yet implemented[ in gfortran]"

That's fine with me. I would include "in gfortran" and possibly add a
"Fortran 2003: " in front, to be consistent with the error msg for
procedure pointers:

  if (attr->procedure && attr->pointer)
    {
      gfc_error ("Fortran 2003: Procedure pointers at %L are "
		"not yet implemented in gfortran", where);
      return FAILURE;
    }

Cheers,
Janus



More information about the Gcc-patches mailing list