[PATCH,SH] Add SH2A new instructions

Naveen H.S. naveen.hs@kpitcummins.com
Mon Oct 8 06:01:00 GMT 2007


Hi,

>> First of all, the patch can't be applied to the trunk cleanly.
>> It seems that you missed the patch in the thread:
Please find attached the modified patches sh2a (1-4).tar.bz2. The
patch is applied on the latest GCC sources (gcc- 4.3-20070921). 

>> Please check again our coding standard:
Thank you for the valuable comments. We have taken care of all the
comments in the modified patch.

>> It seems that your patch could be divided into 4-5 parts at least.
>> It'll help not only reviewing but also investigating which part 
>> causes problems.
We have divided the patch into four parts. The patches should be 
applied in the following particular sequence:-
1. sh2a1.patch: RTS/N, JSR/N, JSR/N @@, RESBANK
2. sh2a2.patch: MOVI20S, MOVRT, NOTT, PREF
3. sh2a3.patch: BSET, BCLR in reg mode
4. sh2a4.patch: BSET, BCLR, BOR, BXOR, BAND, BLD, BST, BANDNOT, BORNOT
and BLDNOT.

>> many of these insns should be replaced with expanders in the first
>> place.
Expanders have been added for all the instructions as per the
suggestion.
However, the call from INSV and EXTV could not be removed as they were
necessary to generate the instructions. Please comment on the approach 
used in the sh2a4.patch for expanders.

The patches are modified as per the valuable comments suggested. Please
find attached the modified Changelog (1-4) as per the modified patches.

Regards,
Naveen.H.S.
KPIT Cummins Infosystems Ltd,
Pune (INDIA) 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~	
Free download of GNU based tool-chains for Renesas' SH, H8, R8C, M16C	
and M32C Series. The following site also offers free technical support	
to its users. Visit http://www.kpitgnutools.com for details. 	
Latest versions of KPIT GNU tools were released on October 1, 2007.	
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~	
	
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sh2a4.patch.tar.bz2
Type: application/octet-stream
Size: 3734 bytes
Desc: sh2a4.patch.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Changelog1.tar.bz2
Type: application/octet-stream
Size: 829 bytes
Desc: Changelog1.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Changelog2.tar.bz2
Type: application/octet-stream
Size: 450 bytes
Desc: Changelog2.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Changelog3.tar.bz2
Type: application/octet-stream
Size: 404 bytes
Desc: Changelog3.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Changelog4.tar.bz2
Type: application/octet-stream
Size: 520 bytes
Desc: Changelog4.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sh2a1.patch.tar.bz2
Type: application/octet-stream
Size: 6784 bytes
Desc: sh2a1.patch.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0005.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sh2a2.patch.tar.bz2
Type: application/octet-stream
Size: 2489 bytes
Desc: sh2a2.patch.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sh2a3.patch.tar.bz2
Type: application/octet-stream
Size: 1387 bytes
Desc: sh2a3.patch.tar.bz2
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20071008/38f43254/attachment-0007.obj>


More information about the Gcc-patches mailing list