Patch: make mapped locations the default

Tom Tromey tromey@redhat.com
Thu Nov 8 13:58:00 GMT 2007


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

>>>>> "Mark" == Mark Mitchell <mark@codesourcery.com> writes:
Mark> Since this project has been around for so long, and was on the
Mark> 4.3 plan, my inclination is as follows:
Mark> 1. Disable column number output.
Mark> 2. Change the default.

Tom> Still, I'll proceed on schedule unless someone else objects.

Here's the updated patch.

This works by flipping the default for -fshow-column.  We still get
column numbers from cpp, because gcc only changes libcpp's setting
when the command-line option is seen.

With this approach, developers can easily enable column number output
with -fshow-column.

Bootstrapped and regtested on x86 FC-6.  Ok?

Tom

ChangeLog:
2007-11-07  Tom Tromey  <tromey@redhat.com>

	* common.opt (fshow-column): Default to 0.
	* configure: Rebuilt.
	* configure.ac (--enable-mapped-location): Default to 'yes'.

Index: configure.ac
===================================================================
--- configure.ac	(revision 129968)
+++ configure.ac	(working copy)
@@ -525,7 +525,7 @@
 
 AC_ARG_ENABLE(mapped-location,
 [  --enable-mapped-location   location_t is fileline integer cookie],,
-enable_mapped_location=no)
+enable_mapped_location=yes)
 
 if test "$enable_mapped_location" = yes ; then
   AC_DEFINE(USE_MAPPED_LOCATION, 1,
Index: common.opt
===================================================================
--- common.opt	(revision 129968)
+++ common.opt	(working copy)
@@ -926,7 +926,7 @@
 Eliminate redundant sign extensions using LCM.
 
 fshow-column
-Common C ObjC C++ ObjC++ Report Var(flag_show_column) Init(1)
+Common C ObjC C++ ObjC++ Report Var(flag_show_column) Init(0)
 Show column numbers in diagnostics, when available.  Default on
 
 fsignaling-nans



More information about the Gcc-patches mailing list