stabilize .gcc_except_table with or without -g

Alexandre Oliva aoliva@redhat.com
Wed Nov 7 06:34:00 GMT 2007


On Nov  5, 2007, DJ Delorie <dj@redhat.com> wrote:

>> Should new the compare function be moved into libiberty proper?

> If it were to be moved into libiberty, I think (1) it would need to
> guard against NULL arguments, and (2) it must assume that two strings
> may compare equal.  Libiberty functions shouldn't abort if they can
> return a meaningful error value.

Works for me.

> As for should it be in libiberty... I think it would be reasonable for
> each hash type to have a "stock" implementation of hashing a simple
> string.

But this is not about hashing at all.  We're talking about no more
than a wrapper for strcmp with different static types for the
arguments.  So I'm not sure it's all that useful for libiberty, but I
can see that it could be convenient.  Your call, really.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the Gcc-patches mailing list