[testsuite] fix C tests to use correct dg-error or dg-warning directive

Janis Johnson janis187@us.ibm.com
Thu May 17 21:07:00 GMT 2007


On Wed, May 16, 2007 at 02:34:32PM +0100, Manuel López-Ibáñez wrote:
> On 16/05/07, Mike Stump <mrs@apple.com> wrote:
> >On May 15, 2007, at 11:34 AM, Janis Johnson wrote:
> >> This currently makes no difference because the DejaGnu support
> >> doesn't pay attention to the message prefix, but Manuel and I are
> >> working on a patch to change that within the GCC testsuite support;
> >> see PR 25241.
> >
> >Wonderful.  I'd vote against dg-gcc-warning, once done, it would
> >never be undone.  :-(   What's your current thinking, one language at
> >a time and not doing dg-gcc-warning?
> >
> 
> The current plan is to fix dg-warning and dg-error for the C
> front-end. (Actually, we already have patches for all C tests
> "failing" at i686).
> 
> We are not going to use a new dg-gcc-warning. Check the comments at
> PR25241 for the complete discussion. There is a small risk that we
> miss some flawed tests in some targets. We hope people will test
> Janis's patch for target-specific tests. If you have any question
> about this, please ask Janis or me.

I checked in the changes to use the correct one of dg-error or dg-warning
in several C tests, adding Manuel to the ChangeLog entry.

For the changes to the gcc-error and gcc-warning test directives, we'll
probably check in the changes and test fixes for C after testing them on
i686-linux and powerpc64-linux.  Tests that fail on other platforms can
be fixed as we notice the failures; I'm sure there will be some.  Next
we'll fix the tests for other languages and enable the new support for
those languages.

Janis



More information about the Gcc-patches mailing list