[PATCH] Fix PR30957

Revital1 Eres ERES@il.ibm.com
Mon May 7 04:35:00 GMT 2007



gcc-patches-owner@gcc.gnu.org wrote on 06/05/2007 18:56:51:

> On Sun, 22 Apr 2007, Revital1 Eres wrote:
>
> >(See attached file: pr30957-1.c.txt)
>
> I can't quote it by simple means in this mailer, as it was
> attached rather than in-text, but did you really mean for the
> test-case to xfail for powerpc-spe and vax (and why the vax)
> rather than skip the test for them?
>
> Or rather: is the better choice not to skip the test for these
> targets?  I'm asking because the test fails for cris-elf as
> well, and I suspect you don't know the test-machinery to express
> the skipping.  Perhaps best a check_effective_target_* thingy
> (grep in testsuite/lib/*.exp) to express what the target must
> have in order for the test-case to be valid?
>

I took the powerpc-spe and vax targets from ieee.exp script as
described in - http://gcc.gnu.org/ml/gcc-patches/2007-04/msg01772.html.
The intention was to disable the test on machines with no hardware
support for IEEE arithmetic thus skipping those targets indeed seems a
better solution.  I am not sure how to skip just one testcase though;
does adding .x file is the right way?  I am also not sure I understand
why this test fail on cris-elf as well.

Thanks,
Revital


> brgds, H-P



More information about the Gcc-patches mailing list