PATCH COMMITTED: Fix Ada build
Thiemo Seufer
ths@networkno.de
Tue May 1 23:19:00 GMT 2007
Ian Lance Taylor wrote:
> My apologies for breaking the Ada build. I didn't think my patch
> could cause it to break, but clearly I was wrong. As far as I can
> tell the code was loosely hanging together before. The Ada frontend
> sets TYPE_MAX_VALUE of a subtype to have the type of the main type.
> This causes VRP to become ineffective in its tests of infinity, but I
> guess that never mattered. The effect of my patch to tree.c to cause
> TYPE_MAX_VALUE of a type variant to have the type of that variant was
> to cause some type mismatches in VRP when using Ada subtypes. These
> type mismatches managed to lead to confusion with Ada subtypes, in
> which the cache of integers associated with each type themselves had
> the wrong type. There may still be something dubious going on in this
> area; I'm not sure.
>
> In any case this patch fixes the VRP problem in PR 31710 in what some
> people think is a better way anyhow, by comparing INT_CSTs by value
> rather than ==.
>
> Bootstrapped and tested on i686-pc-linux-gnu, including Ada.
> Committed to mainline. I will commit to 4.2 branch when it is open
> for changes.
Thanks, this fixes the Linux/MIPS Kernel build breakage I saw with
your previous tree-vrp patch.
Thiemo
More information about the Gcc-patches
mailing list