[PATCH][C++] Remove 99% calls to expr*location
Wed Mar 28 16:28:00 GMT 2007
Are you saying there was an incomplete checkin to trunk for
those changes? If so how does this impact gcc 4.2 branch (assuming
that the changes were already approved but never checked in)?
If this provides a nice compile time performance improvement it
might be worth trying to get it into gcc 4.2 branch as well.
On Wed, Mar 28, 2007 at 05:00:32PM +0200, Richard Guenther wrote:
> On Wed, 28 Mar 2007, Richard Guenther wrote:
> The locus saving was introduced by the tree-ssa merge and there by
> Branch: tree-ssa-20020619-branch
> Changes by: firstname.lastname@example.org 2004-04-19 17:38:43
> Modified files:
> gcc : c-common.c
> gcc/cp : ChangeLog.tree-ssa except.c tree.c
> Log message:
> * c-common.c (c_walk_subtrees): Save and restore input_location.
> * except.c (check_handlers_1): Use locus stored in master for
> * tree.c (cp_walk_subtrees): Save and restore input_location.
> but I don't see the c-common.c part ever reached mainline (at least it
> doesn't appear in the tree-ssa changelog) and c_walk_subtree was removed
> 2004-06-26 Richard Kenner <email@example.com>
> * c-common.c (c_safe_from_p, c_walk_subtrees): Deleted.
> * c-common.def (DECL_STMT): Remove.
> * c-common.h (DECL_STMT_DECL): Deleted.
> (COMPOUNT_LITERAL_EXPR_DECL): Use DECL_EXPR_DECL.
> (c_safe_from_p, c_walk_subtrees): Deleted.
> - /* Set input_location here so we get the right instantiation context
> - if we call instantiate_decl from inlinable_function_p. */
> - save_locus = input_location;
> - if (EXPR_LOCUS (*tp))
> - input_location = *EXPR_LOCUS (*tp);
> so maybe it's just an oversight the cp variant survived?
More information about the Gcc-patches