[PATCH, libgomp]: Cleanup test files in testsuite/libgomp.c directory

Uros Bizjak ubizjak@gmail.com
Sun Mar 18 13:13:00 GMT 2007


Joseph S. Myers wrote:

>> Attached patch fixes this by checking current_target_name for "/-m32" string
>> for x86_64-*-* targets and by setting ALWAYS_CFLAGS to -march=i486 if the
>> pattern is found. This is consistent with libgomp's configure.tgt.
>>     
>
> Rather than checking option text like that, you should always handle 
> x86_64 and i?86 the same in the testsuite but use 
> check_effective_target_lp64 / check_effective_target_ilp32 to determine 
> whether the current multilib is 32-bit or 64-bit.  See 
> check_effective_target_vect_cmdline_needed in target-supports.exp for an 
> example like that:
>
>              || (([istarget x86_64-*-*] || [istarget i?86-*-*])
>                  && [check_effective_target_lp64])
>   
This was the first thing I tried but unfortunately, it currently doesn't 
work because in this case libgomp_init  calls get_compiler_messages 
(called from check_effective_target_*) that calls 
libgomp_target_compile, and this loops back to libgomp_init. I'll look 
into this issue, but this involves more surgery...

Uros.



More information about the Gcc-patches mailing list