[PATCH, libgomp]: Cleanup test files in testsuite/libgomp.c directory

Joseph S. Myers joseph@codesourcery.com
Sun Mar 18 09:13:00 GMT 2007


On Sat, 17 Mar 2007, Uros Bizjak wrote:

> Attached patch fixes this by checking current_target_name for "/-m32" string
> for x86_64-*-* targets and by setting ALWAYS_CFLAGS to -march=i486 if the
> pattern is found. This is consistent with libgomp's configure.tgt.

Rather than checking option text like that, you should always handle 
x86_64 and i?86 the same in the testsuite but use 
check_effective_target_lp64 / check_effective_target_ilp32 to determine 
whether the current multilib is 32-bit or 64-bit.  See 
check_effective_target_vect_cmdline_needed in target-supports.exp for an 
example like that:

             || (([istarget x86_64-*-*] || [istarget i?86-*-*])
                 && [check_effective_target_lp64])

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list