output # <srcline> between #APP and #NO_APP, for asm statements

Alexandre Oliva aoliva@redhat.com
Sat Mar 17 00:35:00 GMT 2007


On Mar 16, 2007, Andreas Schwab <schwab@suse.de> wrote:

> Alexandre Oliva <aoliva@redhat.com> writes:
>> -    if test $gcc_cv_gas_vers -ge `expr \( \( elf,2,16,91 \* 1000 \) + gcc_cv_as_line_zero=yes \) \* 1000 + `
>> +    if test $gcc_cv_gas_vers -ge `expr \( \( 2,16,91 \* 1000 \) + gcc_cv_as_line_zero=yes \) \* 1000 + `

> How is this suposed to work?

Easy.  Someone actually tests the feature in a unified tree and finds
it's broken, or some attentive eyes catch it and report it.  Then, the
embarrassed developer who should have noticed it himself installs a
patch after testing it on a unified tree, where it should have been
tested in the first place, and, voila, it works ;-)

:-/

Here's what I'm checking in, thanks,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-asm-line-config-check-fix.patch
Type: text/x-patch
Size: 1555 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20070317/ea9c6124/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


More information about the Gcc-patches mailing list