[Fortran, Patch] PR31188 - Allow array dummy as range for constant arrays

Tobias Burnus burnus@net-b.de
Thu Mar 15 21:58:00 GMT 2007


Hi,

FX Coudert wrote:
> Paul proposed another patch in the PR trail, which looks cleaner to me
> as it doesn't add the expr_const arg. Now I imagine there was a reason
> for you adding it in the first place, could you comment on Paul's
> patch (or could Paul comment on your patch)?
Well, I followed AR_ELEMENT and return SUCCESS if gfc_simplify_expr
cannot be more simplified.
Paul takes the simple route and returns FAILURE in this case.

I would argue that SUCCESS is a bit cleaner conceptually, but FAILURE is
cleaner in terms of the code.

Since the return value of gfc_simplify_expr is ignored, one can return
anything.


Tobias

PS: Sorry for not adding a proper subject to the email I sent a minute
ago; I realized just after I hit send :-(



More information about the Gcc-patches mailing list