PATCH: Fix integer/pointer size mismatch in splay-tree.h

Kai Tietz Kai.Tietz@onevision.com
Tue Mar 13 09:48:00 GMT 2007


DJ Delorie <dj@redhat.com> 
12.03.2007 19:40

To
Kai.Tietz@onevision.com
cc
gcc-patches@gcc.gnu.org, bje@au1.ibm.com
Subject
Re: PATCH:  Fix integer/pointer size mismatch in splay-tree.h







>> As to see, this patch is obvious. Sorry, that I posted it first to
>> the wrong news group.

>Patches which change a public API are *never* obvious.  This one in
>particular is incorrect on m32c, for example, where size_t is smaller
>than long.


Ok, not obvious, but obviously wrong for targets with type long less than 
a pointer size. By the reason that GTY is used for this type, an #if - 
clause won't help.
What's to do in your opinion ? May introducing eg. in ansidecl.h (but of 
course it is not really an ansi issue) a type with the size 
max(sizeof(long),sizeof(void*)) ?



More information about the Gcc-patches mailing list