output # <srcline> between #APP and #NO_APP, for asm statements

Alexandre Oliva aoliva@redhat.com
Mon Mar 12 22:02:00 GMT 2007


On Mar  9, 2007, Alexandre Oliva <aoliva@redhat.com> wrote:

> Likewise.  Sorry.  I'm now sure something went wrong in my testing the
> original patch.

AFAICT, my goof was that, when my baseline testing completed, I
thought my patch testing was complete.  Same failures as in the
previous baseline, good to go, yay.

I'm going to change my testing procedures to avoid this mistake
again.  Apologies for the breakage.


Now, I'm told this patch has caused other regressions.  Looking into
it, I found out gas hasn't accepted # 0 "" forever; it has rather only
started accepting it with this patch:

revision 1.105
date: 2005/08/07 10:34:52;  author: nickc;  state: Exp;  lines: +10 -2
(s_app_line): Accept a line number of 0 for compatibility with gcc's output
for assembler-with-cpp files.

It was a while ago, but I'll look into a configure test to verify
whether we should generate the # 0 "" lines.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the Gcc-patches mailing list