[PATCH] PR tree-optimization/29877: handling of register vars during TER

Mark Shinwell shinwell@codesourcery.com
Tue Mar 6 16:28:00 GMT 2007


Andrew MacLeod wrote:
> On Mon, 2007-01-08 at 08:37 +0000, Mark Shinwell wrote:
>> Richard Guenther wrote:
>>> On 1/3/07, Mark Shinwell <shinwell@codesourcery.com> wrote:
>>>> Mark Shinwell wrote:
>>>>> This patch fixes PR29877, which concerns erroneous extensions of
>>>>> the lifetimes of register variables.  This was being caused by the
>>>>> TER pass incorrectly removing assignments with a register variable
>>>>> on the RHS.
>>>>>
>>>>> There was some discussion internally as to what to do about the
>>>>> somewhat fragile testcase involved in the patch; that below was
>>>>> eventually settled on.
>>>>>
>>>>> This patch causes no regressions on x86_64-unknown-linux-gnu with all
>>>>> default languages enabled.  OK to apply to mainline?
>>>> Ping, please.
>>> This is ok for mainline if you re-bootstrap & test.
>> I have applied this as follows -- there are a couple of extra lines in the
>> patch now because this TER modification means that the dg-error directives
>> in pr16194.c added recently by Honza are no longer required.
>>
>> Bootstrapped and tested with no regressions on x86_64-unknown-linux-gnu.
>>
>> Should I also prepare and apply patches for this for 4.1 and 4.2 once
>> clean testsuite results have been obtained?
> 
> I think we should apply this to 4.2 now. Its a safe fix and resolves the
> PR.  I don't think you have done that yet have you?  Or I can do it if
> you want.

Yeah, I'll do it this week.

Mark



More information about the Gcc-patches mailing list