[PATCH] Modulo-scheduling improvements. Patch 2 of 2.

Andrew Pinski pinskia@gmail.com
Sat Jun 23 00:29:00 GMT 2007


On 6/22/07, David Edelsohn <dje@watson.ibm.com> wrote:
> >>>>> Ayal Zaks writes:
>
> > Note that you need an spu maintainer to approve the spu.md part, and a loop
> > optimizer maintainer to approve the doloop part. David, Zdenek, can you
> > look into these parts, attached below, and see if they are acceptable?
>
>          Andrew Pinski would be the best person to review the SPU part of
> the patch.

Note the patch can be found at
http://gcc.gnu.org/ml/gcc-patches/2007-01/msg01470.html

Actually Trevor would be a better person in this case.  This is
because I remember that Trevor found the doloop_end pattern actually
caused performance regressions but I don't have further information
than just that, sorry.

I also will note that we really don't need a doloop pattern to find
loops or to look at the iteration of loops at the RTL level. cfgloop.h
contains all the functions we could use to find the loops and their
iterations.  In fact this is how loop-doloop.c (which is 640 lines
long) finds those loops.
Please read loop-doloop.c (specifically doloop_optimize)  for a way to
find the loops and iterations.

If we do add a do_loop_end pattern to the spu back-end in the end, can
we then make it dependent it on sms being enabled?

Thanks,
Andrew Pinski



More information about the Gcc-patches mailing list