[PATCH][dbgcnt] New debug counter global_alloc_at_func, global_alloc_at_reg, and make sched_insn work

Maxim Kuvyrkov maxim@codesourcery.com
Tue Jun 19 07:55:00 GMT 2007


Seongbae Park (???, ???) wrote:
> It has already bootstrapped on ia64.
> I'm running the bootstrap & regtest on x86-64.
> This is for debugging  and should not affect the code correctness
> unless enabled.
> Ok if all tests pass ?

I'm not the maintainer and can't approve this patch, but below are my 
suggestions that you can fully disregard.

> 
> 2007-06-18  Seongbea Park  <seongbae.park@gmail.com>

You've misspelled your name :)

>            Maxim Kuvyrkov  <mkuvyrkov@ispras.ru>
> 
>        * dbgcnt.def (global_alloc_at_func, global_alloc_at_reg):
>        New counters.
>        * haifa-sched.c (queue_to_ready): Pick the next insn if
>        dbgcnt(sched_insn) reaches the limit.

I would write: Don't requeue next insn is dbg_cnt (sched_insn) reaches 
the limit

>        (choose_ready): New parameter INSN_PTR and new return value.
>        (schedule_block): Handle dbgcnt(sched_insn). Handle
>        the new return value from choose_ready.

I would change dgbcnt(sched_insn) to dgb_cnt (sched_insn).

>        * global.c (global_aloc): New dbgcnt global_alloc_at_reg.
>        (rest_of_handle_global_alloc): New global_alloc_at_func.


Regards,

Maxim



More information about the Gcc-patches mailing list