[PATCH, middle-end, i386]: reciprocal rsqrt pass + full recip x86 backend support

Diego Novillo dnovillo@google.com
Sat Jun 16 12:27:00 GMT 2007


On 6/16/07 6:05 AM, Uros Bizjak wrote:

> f) No maintainer expressed any concerns about this patch.

Not a big concern, but something we should think about.  In
tree-ssa-math-opts.c we already had a pass to cse sin and cos.  This
pass is mechanically similar to that one.  It does a linear scan over
the CFG applying these peephole transformations.

Perhaps it would be a good idea to do a single scan that calls back to
all these transformations on every statement?  I realize that each pass
requires its own setup and may need to do things a bit differently, but
perhaps we can save ourselves multiple IL scans if we generalize it a bit.

Other than that, the patch is fine.



More information about the Gcc-patches mailing list